MLE-26427 More Polaris fixes #1882
Conversation
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR addresses Polaris static analysis findings by adding null safety checks and removing redundant null checks.
Changes:
- Added explicit null check with
Objects.requireNonNull()for response object - Removed redundant null check for response object that was already guaranteed non-null
- Added early return for null content in serialization method
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| OkHttpServices.java | Enforces non-null response contract and removes redundant null check |
| IncrementalWriteFilter.java | Adds null safety check for content serialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Response response = sendRequestWithRetry(requestBldr, sendRequestFunction, resendableConsumer); | ||
|
|
||
| Objects.requireNonNull(response); |
There was a problem hiding this comment.
The Objects.requireNonNull() call should include a descriptive error message as the second parameter to help with debugging if the response is unexpectedly null. For example: Objects.requireNonNull(response, \"Response from sendRequestWithRetry cannot be null\").
| Objects.requireNonNull(response); | |
| Objects.requireNonNull(response, "Response from sendRequestWithRetry cannot be null"); |
No description provided.